Refactor SparkClient constructors#1318
Merged
sonalgoyal merged 1 commit intoApr 30, 2026
Merged
Conversation
add overloads that accept a zFactoryClassName string.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors SparkClient construction to add overloads that accept a zFactoryClassName string, aligning with issue #1317 (factory-based constructors to avoid NPEs) and reducing constructor duplication.
Changes:
- Refactored existing
SparkClientconstructors to delegate viathis(...)to centralize initialization. - Added new
SparkClientoverloads that accept azFactoryClassName(with and without an explicitSparkSession). - Updated
.gitignoreto ignore a Python virtual environment directory.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spark/client/src/main/java/zingg/spark/client/SparkClient.java | Adds zFactory-based constructor overloads and refactors existing constructors to delegate. |
| .gitignore | Ignores /python/venv directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add overloads that accept a zFactoryClassName string. fixes #1317